mirror of
https://github.com/microsoft/GSL.git
synced 2024-11-03 17:56:43 -05:00
9ff6e19ea9
* Added c++17 test configurations for clang5.0 and clang6.0 * Removed explicit not_null constructor, sloppy_not_null, added strict_not_null We added explicit not_null constructor in version 2.0.0. It proved very difficult to switch to the new version for large code bases that adopted previous versions of gsl, due to not_null used extensively in the code. Still, using explicit constructor is very benefitial for new code, since it encorages better API design and make null checks intentional. To resolve the issue, this change: - removes explicit keyword from not_null constructor - removes unneded sloppy_not_null type - adds strict_not_null type to behave the same way as v2 not_null - updates tests * Removed explicit not_null constructor, sloppy_not_null, added strict_not_null We added explicit not_null constructor in version 2.0.0. It proved very difficult to switch to the new version for large code bases that adopted previous versions of gsl, due to not_null used extensively in the code. Still, using explicit constructor is very benefitial for new code, since it encorages better API design and make null checks intentional. To resolve the issue, this change: - removes explicit keyword from not_null constructor - removes unneded sloppy_not_null type - adds strict_not_null type to behave the same way as v2 not_null - updates tests * fixed build break for gcc7 * added more tests * added more non-compiling tests * Addressed PR comments and suppressed a code analysis warning * Fixed test failure in not_null tests |
||
|---|---|---|
| .. | ||
| algorithm_tests.cpp | ||
| assertion_tests.cpp | ||
| at_tests.cpp | ||
| bounds_tests.cpp | ||
| byte_tests.cpp | ||
| CMakeLists.txt | ||
| multi_span_tests.cpp | ||
| no_exception_ensure_tests.cpp | ||
| no_exception_throw_tests.cpp | ||
| notnull_tests.cpp | ||
| owner_tests.cpp | ||
| span_tests.cpp | ||
| strict_notnull_tests.cpp | ||
| strided_span_tests.cpp | ||
| string_span_tests.cpp | ||
| test.cpp | ||
| utils_tests.cpp | ||