29 Commits

Author	SHA1	Message	Date
Werner Henze	1cdb8d295e	More checks for non-compilable code, plus fix for span (#1180)	2025-01-04 11:50:31 -06:00
Werner Henze	fcd55ee924	Better use of std::enable_if (#1177) ... * this commits adds tests that should fail, but don't * Better use of std::enable_if Replace the occurances of `class = std::enable_if_t<Cond>` and `typename = std::enable_if_t<Cond>` that have been identified in the previous commit with `std::enable_if_t<Cond, bool> = true`. This commit is inspired by #1174, which changed one occurance in the owner header. This commit is aimed to fix all remaining occurances. * fix failing checks - core.cxx_gsl aktualisiert auf [](https://gitlab.avm.de/fos/repos/core.cxx_gsl/-/commit/) - plc.access_lib aktualisiert auf [](https://gitlab.avm.de/fos/repos/plc.access_lib/-/commit/) - plc.common aktualisiert auf [](https://gitlab.avm.de/fos/repos/plc.common/-/commit/) - plc.daemon aktualisiert auf [](https://gitlab.avm.de/fos/repos/plc.daemon/-/commit/) - Test Plan: - --------- Co-authored-by: Werner Henze <werner.henze+gitcommits@posteo.de> Co-authored-by: Werner Henze <w.henze@avm.de>	2024-12-23 10:40:22 -06:00
Werner Henze	b8ac820fe1	Force unit tests for byte to use GSL implementation (#1176) ... When setting `GSL_USE_STD_BYTE` to zero, then the unit test does not compile because `byte` is ambiguous (could be `std::byte` or `gsl::byte`). So `gsl::` prefix is needed for `byte`. It looks like the unit tests never ran on a platform where `gsl::byte` is not based on `std::byte`. It does not make much sense to test `std::byte` for compliance, so make the unit tests based on the GSL implementation of `gsl::byte` (`#define GSL_USE_STD_BYTE 0`). Co-authored-by: Werner Henze <werner.henze+gitcommits@posteo.de>	2024-12-18 10:16:36 -06:00
Edward Chen	52212c2d76	Update Clang GSL_SUPPRESS to stringize parameter instead of using fixed string literal. (#1133) ... Fix #1130.	2023-09-11 10:52:30 -07:00
Werner Henze	3ba80d5dd4	simplify to_byte (#1090) ... - to_byte_impl is not necessary, the same can be achieved with shorter code - add test code for things that should not compile	2023-02-14 14:10:56 -08:00
Jordan Maples [MSFT]	b26f6d5ec7	gsl::at behavior change regarding gsl::span (#985) ... * move span specialization of 'at' to <gsl/span> and update the parameter to be taken by reference * undid previous changes and acted upon decisions made in maintainer sync. Fixed tests failing in /kernel mode * ran clang-format on the include folder * ran clang-format on the test folder Co-authored-by: Jordan Maples <jordan.maples@microsoft.com>	2021-05-20 18:18:08 -07:00
Jordan Maples [MSFT]	a150aaa4ed	renaming main logic files. Added warning message of the removal and include passthrough. Renamed includes in the source files. Ran Clang-Format (#946) ... Header rename	2020-10-29 17:38:48 -07:00
Roelf-Jilling	81f56796a1	MSVC and CoreChecker warning suppression for tests to CMake ... Suppress CppCoreCheck warnings on GTest macros. Suppress CppCoreCheck advice to use the GSL	2020-01-16 11:49:15 +01:00
Roelf-Jilling	186f5d21c1	Move compiler warning suppression for tests from cpp files to CMake	2020-01-16 11:49:00 +01:00
Jordan Maples [MSFT]	f04907c2f6	added suppression for missing destructor override	2020-01-08 10:13:00 -08:00
Jordan Maples [MSFT]	8577033f13	addressing comments	2019-12-19 14:05:02 -08:00
Jordan Maples	9a88262544	fixing suppression of gtest warnings for gcc	2019-12-06 16:03:47 -08:00
Jordan Maples [MSFT]	87eaa45445	suppressing -Wundef in clang (GTest emitted)	2019-12-04 12:48:13 -08:00
Jordan Maples [MSFT]	43aca2646b	ignore warnings from gtest	2019-12-04 12:30:58 -08:00
Jordan Maples [MSFT]	2b10729386	gtest migration	2019-12-03 14:32:25 -08:00
Anna Gringauze	cea0d0ac2b	fix cppcorecheck warnings (#703) ... * Added c++17 test configurations for clang5.0 and clang6.0 * Fixed CppCoreCheck warnings in GSL and tests - Added CMakeSettings.json for VS Open Folder configuration - So we can easily run CppCoreCheck in VS - Fixed CppCorecheck warnings where it made sense - Suppressed the rest - Some suppression does not work due to compiler/tool bugs, so replaced by #pragma disable - CppCoreCheck has noise, suppressed those with comments - Catch produces many warnings, blanket-supressed them all - Had to fix clang formatting to keep attributes in place - clang-format does not support attributes, so I am using - "CommentPragmas: '^ NO-FORMAT:'" to skip formatiting on them - Removed GSL_NOEXCEPT macro, removed incorred noexcepts * Ignore unknown attributes * ignore unknown attributes in noexception mode tests * fixed C26472 in at() * created GSL_SUPPRESS macro to allow all compilers to parse suppression attributes * try to fix gcc compilation problems with attributes * ignore gsl::suppress for gcc * move suppression to function level on return statements clang5.0 and up does not allow attributes on return statemets in constexpr functions * move suppression to function level on return statements * use GSL_SUPPRESS in algorithm_tests * Addressed PR comments	2018-08-12 21:44:17 -07:00
Tiago	0d33bf6794	Applied iwyu --comment to the code base (#588)	2017-11-28 07:13:49 -08:00
Neil MacIntosh	b2ee484334	Move from unittest-cpp to catch for unit testing. (#533) ... Many thanks to @rianquinn. This should fix #495, #494 and #529.	2017-07-13 13:53:56 -07:00
Tiago	ebe7ebfd85	Reformat files to follow clang-format style (#492) ... Project files were not following the clang-format style. For people using IDEs were clang-format is always run after a save this would cause unwanted changes. This commit only applies "clang-format -i" to files.	2017-04-20 07:51:37 -07:00
MikeGitb	ade86caa92	Fix some corechecker warnings (#470) ... * Improve const correctness in string_span * Improve const correctness in bounds_tests.cpp and byte_tests.cpp * Improve const correctness in span_tests.cpp * Improve const correctness in utils_tests.cpp * Use gsl::owner for dynamically allocated memory in string_span_tests.cpp * Improve const correctness in string_span_tests.cpp * Improve const correctness for strided_span_tests.cpp	2017-04-02 12:30:49 -07:00
MikeGitb	1287e624cd	Address #313: try to guard against strict-aliasing bugs with gsl::byte ... * Add test to demonstrate byte aliasing problem on g++ and clang++ * Add note about no-strict-aliasing flag in README * Activate aliasing unit test and use -fno-strict-aliasing flag	2016-10-17 12:36:11 -07:00
Martin Moene	ad991370da	Add tests for to_integer(): they fail	2016-09-17 09:16:15 +02:00
Kris Cruickshank	55b232dde4	Issue: #329 ... This is my best attempt at fixing the issues raised by @gdr-at-ms while supporting VS2013, VS2015, providing shorter syntax than the static_cast and giving developer meaningful errors when they do the wrong thing.	2016-09-07 21:38:43 +01:00
Kris	95bbaa1ec2	Added to_byte method for issue #329 ... I have added the to_byte method and updated the unit tests. This gives slightly nicer syntax than static_cast, is better than the c-style cast used in the unit test. See: https://github.com/Microsoft/GSL/issues/329#issuecomment-240588515	2016-08-28 21:55:58 +01:00
Galik	222c2d85fd	Removed .h extension from header files.	2016-08-10 17:24:00 +01:00
galik	f6cc5798a1	Renamed include/ folder to gsl/ to make including the library consistent ... whether using it from the development folder, from the installation folder or from being copied into a project. #include <gsl/gsl.h> Updated headers/tests/instructions/cmake build accordingly This PR should address https://github.com/Microsoft/GSL/issues/277 (less the renaming of gsl itself)	2016-08-09 15:04:58 +01:00
Neil MacIntosh	8855c59579	Added basic compile support for MSVC 2013 to byte.	2016-07-15 17:31:40 -07:00
Neil MacIntosh	267472449c	Renamed byte header and tidied up string_span dependencies.	2016-06-26 17:00:56 +03:00
Neil MacIntosh	b72d7abfb0	Added definition of gsl::byte to match proposed std::byte.	2016-06-24 04:54:09 -07:00