13 Commits

Author	SHA1	Message	Date
Carson Radtke	4742bc192a	use relative path in # include (#1194) ... Reverts commit that changes #include "assert" -> #include "gsl/assert". This change is necessary in order to comply with CppCoreGuideline's SF.12. Now we do #include "./assert".	2025-02-12 09:16:45 -06:00
Tiago	7b6b8013b1	Add "gsl" to #includes (#1184) ... Office is seeing build breaks due to `#include "span"` including C++20 span instead of gsl/span. Most likely we want all headers includes qualified with "gsl/" to avoid similar issues.	2025-01-07 08:42:38 -06:00
mq白	32511b8de4	Delete the useless 'noexcept(false)' (#1152)	2024-10-14 15:30:40 -05:00
dmitrykobets-msft	46c72713f2	Document potentially confusing behavior in gsl::narrow (#1073) ... NaN != Nan, so the comparisons used in gsl::narrow will always throw when attempting to cast a NaN value. This may be surprising, so document it.	2022-12-24 11:49:26 -08:00
dmitrykobets-msft	d8c493c89f	Suppress es.46 warning in implementation of gsl::narrow (#1046) ... As per the CoreGuidelines, gsl::narrow is defined in terms of static_cast. Suppress es.46, which suggests converting the static_cast into gsl::narrow	2022-04-28 09:49:38 -07:00
dmitrykobets-msft	7fefaaf2c8	Fix reason for including assert inside gsl/narrow (#1045)	2022-04-28 09:49:10 -07:00
Juan Carlos Arevalo Baeza	f21f29d210	gsl/narrow should include <exception> (#1044) ... This file uses std::exception, so it should include the appropriate header. Normally it gets the STL's <exception> header included via the gsl/assert file, but this is skipped with _HAS_EXCEPTIONS=0. I understand _HAS_EXCEPTIONS is undocumented and unsupported, but regardless, the appropriate header should be included here. Alternatively, gsl/narrow should be modified to support _HAS_EXCEPTIONS=0, like gsl/assert was. But I'm not proposing that change. <exception> does define std::exception even with _HAS_EXCEPTIONS=0.	2022-04-26 14:41:10 -07:00
dmitrykobets-msft	2bfd495080	Suppress -Wfloat-equal warning in implementation of gsl::narrow (#1043) ... In the implementation of gsl::narrow, there is a comparison `static_cast<U>(t) != u` which may be comparing two floats. The comparison here is done purposefully to categorize ill effects of narrowing conversion, since the values being compared *should* be the same when compared with `operator==`. Note, using #pragma GCC will suppress this warning for both GCC and Clang.	2022-04-14 11:08:28 -07:00
Werner Henze	4377f6e603	quoted form of #include when GSL includes GSL files (#1030) ... [SF.12: Prefer the quoted form of #include for files relative to the including file and the angle bracket form everywhere else](https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#Rs-incform) Additionally changed #include order in `span` so that all `span_ext` is in the GSL include block and not in the STL include block. Fixes issues #1025. Co-authored-by: Werner Henze <w.henze@avm.de>	2022-01-31 13:06:42 -08:00
dmitrykobets-msft	99a29ce797	Document safe usage of undefined behavior in gsl::narrow (#1024)	2022-01-26 16:44:07 -08:00
Johel Ernesto Guerrero Peña	8a4b9ed0bf	feat: narrow for non totally ordered types (#986)	2021-06-23 15:28:45 -07:00
Jordan Maples [MSFT]	b26f6d5ec7	gsl::at behavior change regarding gsl::span (#985) ... * move span specialization of 'at' to <gsl/span> and update the parameter to be taken by reference * undid previous changes and acted upon decisions made in maintainer sync. Fixed tests failing in /kernel mode * ran clang-format on the include folder * ran clang-format on the test folder Co-authored-by: Jordan Maples <jordan.maples@microsoft.com>	2021-05-20 18:18:08 -07:00
Jordan Maples [MSFT]	a150aaa4ed	renaming main logic files. Added warning message of the removal and include passthrough. Renamed includes in the source files. Ran Clang-Format (#946) ... Header rename	2020-10-29 17:38:48 -07:00