para/GSL
1
0
Fork 0
mirror of https://github.com/microsoft/GSL.git synced 2024-11-03 17:56:43 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix overflow found by GCC in basic_zstring_span::as_string_span().

Browse Source 
This patch fixes an overflow that was identified with
strict overflow warnings enabled, and optimizations
turned on

Signed-off-by: “Rian <“rianquinn@gmail.com”>
This commit is contained in:
Rian Quinn 2016-10-28 00:45:54 -06:00 committed by Neil MacIntosh
parent 6cffe0d14c
commit f4486389b8
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
gsl/string_span
View File

@ -554,7 +554,8 @@ public:
constexpr string_span_type as_string_span() const noexcept constexpr string_span_type as_string_span() const noexcept
{ {
return span_.first(span_.size() - 1); auto sz = span_.size();
return span_.first(sz <= 0 ? 0 : sz - 1);
} }
constexpr string_span_type ensure_z() const noexcept { return gsl::ensure_z(span_); } constexpr string_span_type ensure_z() const noexcept { return gsl::ensure_z(span_); }