para/GSL
1
0
Fork 0
mirror of https://github.com/microsoft/GSL.git synced 2024-11-03 17:56:43 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #829 from JordanMaples/dev/jomaples/deprecate_span_non_std_functions

Browse Source 
Deprecate span::at & span::operator(). See #828.
This commit is contained in:
Jordan Maples [MSFT] 2020-01-10 10:19:32 -08:00 committed by GitHub
commit 96b6964b30
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
include/gsl/span
View File

@ -509,9 +509,13 @@ public:
Expects(CheckRange(idx, storage_.size())); Expects(CheckRange(idx, storage_.size()));
return data()[idx]; return data()[idx];
} }
// at and operator() are deprecated to align to the public member functions of std::span
[[deprecated("Use operator[]")]]
constexpr reference at(index_type idx) const noexcept{ return this->operator[](idx); } constexpr reference at(index_type idx) const noexcept{ return this->operator[](idx); }
[[deprecated("Use operator[]")]]
constexpr reference operator()(index_type idx) const noexcept{ return this->operator[](idx); } constexpr reference operator()(index_type idx) const noexcept{ return this->operator[](idx); }
constexpr pointer data() const noexcept { return storage_.data(); } constexpr pointer data() const noexcept { return storage_.data(); }
// [span.iter], span iterator support // [span.iter], span iterator support

4
tests/span_tests.cpp
View File

@ -17,8 +17,7 @@
#ifdef _MSC_VER #ifdef _MSC_VER
// blanket turn off warnings from CppCoreCheck from catch // blanket turn off warnings from CppCoreCheck from catch
// so people aren't annoyed by them when running the tool. // so people aren't annoyed by them when running the tool.
#pragma warning(disable : 26440 26426 26497 4189) // from catch #pragma warning(disable : 26440 26426 26497 4189 4996)
#endif #endif
#if __clang__ || __GNUC__ #if __clang__ || __GNUC__
@ -26,6 +25,7 @@
#pragma GCC diagnostic push #pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wundef" #pragma GCC diagnostic ignored "-Wundef"
#pragma GCC diagnostic ignored "-Wunused-variable" #pragma GCC diagnostic ignored "-Wunused-variable"
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
#endif // __clang__ || __GNUC__ #endif // __clang__ || __GNUC__
#if __clang__ #if __clang__