mirror of
https://github.com/microsoft/GSL.git
synced 2024-11-28 18:41:57 -05:00
[ci]: fix android job
Job has been failing for months and is preventing other PRs from getting merged. This PR fixes the pipeline - it changed the following: - runs on macos-latest-large (which is a non-arm image) - starts the emulator under java8 (see https://learn.microsoft.com/en-us/java/openjdk/transition-from-java-8-to-java-11) - runs emulator with -no-audio The above were requirements to get the pipeline running. Other changes include the following: - The job will auto-cancel when a newer commit is pushed to the PR. - The 'Wait for emulator ready' step now has a 2 minute timeout. This is necessary because we get no indication on whether or not the command that started the emulator suceeded. I believe there is room for improvement here, but it is outside the scope of the PR.
This commit is contained in:
parent
b39e7e4b09
commit
94203d18ba
23
.github/workflows/android.yml
vendored
23
.github/workflows/android.yml
vendored
@ -1,4 +1,9 @@
|
|||||||
name: CI_Android
|
name: CI_Android
|
||||||
|
|
||||||
|
concurrency:
|
||||||
|
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
|
||||||
|
cancel-in-progress: true
|
||||||
|
|
||||||
on:
|
on:
|
||||||
push:
|
push:
|
||||||
branches: [ main ]
|
branches: [ main ]
|
||||||
@ -7,7 +12,7 @@ on:
|
|||||||
|
|
||||||
jobs:
|
jobs:
|
||||||
Android:
|
Android:
|
||||||
runs-on: macos-latest
|
runs-on: macos-latest-large
|
||||||
defaults:
|
defaults:
|
||||||
run:
|
run:
|
||||||
working-directory: build
|
working-directory: build
|
||||||
@ -18,15 +23,19 @@ jobs:
|
|||||||
run: mkdir -p build
|
run: mkdir -p build
|
||||||
working-directory: .
|
working-directory: .
|
||||||
|
|
||||||
- name: Start emulator
|
- uses: actions/setup-java@v4
|
||||||
|
with:
|
||||||
|
java-version: 8
|
||||||
|
distribution: zulu
|
||||||
|
|
||||||
|
- name: Start Emulator
|
||||||
run: |
|
run: |
|
||||||
echo "y" | $ANDROID_HOME/tools/bin/sdkmanager --install 'system-images;android-24;default;x86_64'
|
echo "y" | $ANDROID_HOME/tools/bin/sdkmanager --install 'system-images;android-24;default;x86_64'
|
||||||
echo "no" | $ANDROID_HOME/tools/bin/avdmanager create avd -n xamarin_android_emulator -k 'system-images;android-24;default;x86_64' --force
|
echo "no" | $ANDROID_HOME/tools/bin/avdmanager create avd -n xamarin_android_emulator -k 'system-images;android-24;default;x86_64' --force
|
||||||
$ANDROID_HOME/emulator/emulator -list-avds
|
$ANDROID_HOME/emulator/emulator -list-avds
|
||||||
echo "Starting emulator"
|
echo "Starting emulator..."
|
||||||
# Start emulator in background
|
nohup $ANDROID_HOME/emulator/emulator -no-audio -no-snapshot -avd xamarin_android_emulator &> /dev/null &
|
||||||
nohup $ANDROID_HOME/emulator/emulator -avd xamarin_android_emulator -no-snapshot > /dev/null 2>&1 &
|
echo "Emulator starting in background"
|
||||||
echo "Emulator starting"
|
|
||||||
|
|
||||||
- name: Configure
|
- name: Configure
|
||||||
run: cmake -Werror=dev -DCMAKE_TOOLCHAIN_FILE=$ANDROID_NDK_LATEST_HOME/build/cmake/android.toolchain.cmake -DANDROID_PLATFORM=16 -DANDROID_ABI=x86_64 -DCMAKE_BUILD_TYPE=Debug ..
|
run: cmake -Werror=dev -DCMAKE_TOOLCHAIN_FILE=$ANDROID_NDK_LATEST_HOME/build/cmake/android.toolchain.cmake -DANDROID_PLATFORM=16 -DANDROID_ABI=x86_64 -DCMAKE_BUILD_TYPE=Debug ..
|
||||||
@ -35,11 +44,11 @@ jobs:
|
|||||||
run: cmake --build . --parallel
|
run: cmake --build . --parallel
|
||||||
|
|
||||||
- name: Wait for emulator ready
|
- name: Wait for emulator ready
|
||||||
|
timeout-minutes: 2
|
||||||
run: |
|
run: |
|
||||||
$ANDROID_HOME/platform-tools/adb wait-for-device shell 'while [[ -z $(getprop sys.boot_completed | tr -d '\r') ]]; do sleep 10; done; input keyevent 82'
|
$ANDROID_HOME/platform-tools/adb wait-for-device shell 'while [[ -z $(getprop sys.boot_completed | tr -d '\r') ]]; do sleep 10; done; input keyevent 82'
|
||||||
$ANDROID_HOME/platform-tools/adb devices
|
$ANDROID_HOME/platform-tools/adb devices
|
||||||
$ANDROID_HOME/platform-tools/adb shell getprop ro.product.cpu.abi
|
$ANDROID_HOME/platform-tools/adb shell getprop ro.product.cpu.abi
|
||||||
echo "Emulator started"
|
|
||||||
|
|
||||||
- name: Deploy tests
|
- name: Deploy tests
|
||||||
run: |
|
run: |
|
||||||
|
@ -146,6 +146,7 @@ else()
|
|||||||
-Wno-global-constructors # GTest
|
-Wno-global-constructors # GTest
|
||||||
-Wno-missing-prototypes
|
-Wno-missing-prototypes
|
||||||
-Wno-padded
|
-Wno-padded
|
||||||
|
-Wno-switch-default
|
||||||
-Wno-unknown-attributes
|
-Wno-unknown-attributes
|
||||||
-Wno-used-but-marked-unused # GTest EXPECT_DEATH
|
-Wno-used-but-marked-unused # GTest EXPECT_DEATH
|
||||||
-Wno-weak-vtables
|
-Wno-weak-vtables
|
||||||
|
Loading…
Reference in New Issue
Block a user