para/GSL
1
0
Fork 0
mirror of https://github.com/microsoft/GSL.git synced 2024-11-25 01:01:58 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fixing cmake developer warning (#972)

Browse Source 
Here is the warning currently being produced:

CMake Warning (dev) at C:/Program Files/CMake/share/cmake-3.19/Modules/GNUInstallDirs.cmake:223 (message):
  Unable to determine default CMAKE_INSTALL_LIBDIR directory because no
  target architecture is known.  Please enable at least one language before
  including GNUInstallDirs.
Call Stack (most recent call first):
  cmake/guidelineSupportLibrary.cmake:20 (include)
  CMakeLists.txt:4 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.

I noted how I fixed the error. This is caused by GNUInstallDirs automatically executing code just by including it.

I also added -Werror=dev to the CI to ensure this never happens again.

Co-authored-by: Juan Ramos <juanr0911@gmail.com>
This commit is contained in:
jpr89 2021-01-19 16:41:25 -05:00 committed by GitHub
parent d9fa328f89
commit 84aeb59f26
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/android.yml vendored
View File

@ -29,7 +29,7 @@ jobs:
echo "Emulator starting" echo "Emulator starting"
- name: Configure - name: Configure
run: cmake -DCMAKE_TOOLCHAIN_FILE=$ANDROID_HOME/ndk-bundle/build/cmake/android.toolchain.cmake -DANDROID_PLATFORM=16 -DANDROID_ABI=x86_64 -DCMAKE_BUILD_TYPE=Debug .. run: cmake -Werror=dev -DCMAKE_TOOLCHAIN_FILE=$ANDROID_HOME/ndk-bundle/build/cmake/android.toolchain.cmake -DANDROID_PLATFORM=16 -DANDROID_ABI=x86_64 -DCMAKE_BUILD_TYPE=Debug ..
- name: Build - name: Build
run: cmake --build . --parallel run: cmake --build . --parallel

1
.github/workflows/ios.yml vendored
View File

@ -21,6 +21,7 @@ jobs:
- name: Configure - name: Configure
run: | run: |
cmake \ cmake \
-Werror=dev \
-GXcode \ -GXcode \
-DCMAKE_SYSTEM_NAME=iOS \ -DCMAKE_SYSTEM_NAME=iOS \
"-DCMAKE_OSX_ARCHITECTURES=arm64;x86_64" \ "-DCMAKE_OSX_ARCHITECTURES=arm64;x86_64" \

3
CMakeLists.txt
View File

@ -8,6 +8,9 @@ project(GSL
LANGUAGES CXX LANGUAGES CXX
) )
# Must include after the project call due to GNUInstallDirs requiring a language be enabled (IE. CXX)
include(GNUInstallDirs)
# Creates a library GSL which is an interface (header files only) # Creates a library GSL which is an interface (header files only)
add_library(GSL INTERFACE) add_library(GSL INTERFACE)

3
cmake/guidelineSupportLibrary.cmake
View File

@ -16,9 +16,6 @@ endif()
# Necessary for 'write_basic_package_version_file' # Necessary for 'write_basic_package_version_file'
include(CMakePackageConfigHelpers) include(CMakePackageConfigHelpers)
# Use GNUInstallDirs to provide the right locations on all platforms
include(GNUInstallDirs)
function(gsl_set_default_cxx_standard min_cxx_standard) function(gsl_set_default_cxx_standard min_cxx_standard)
set(GSL_CXX_STANDARD "${min_cxx_standard}" CACHE STRING "Use c++ standard") set(GSL_CXX_STANDARD "${min_cxx_standard}" CACHE STRING "Use c++ standard")

2
pipelines/steps.yml
View File

@ -3,7 +3,7 @@ steps:
name: Configure name: Configure
inputs: inputs:
workingDirectory: build workingDirectory: build
cmakeArgs: '-DCMAKE_CXX_STANDARD=$(GSL_CXX_STANDARD) -DCMAKE_BUILD_TYPE=$(BUILD_TYPE) .. ' cmakeArgs: '-DCMAKE_CXX_STANDARD=$(GSL_CXX_STANDARD) -DCMAKE_BUILD_TYPE=$(BUILD_TYPE) -Werror=dev .. '
- task: CMake@1 - task: CMake@1
name: Build name: Build