para/GSL
1
0
Fork 0
mirror of https://github.com/microsoft/GSL.git synced 2024-11-03 17:56:43 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Added conversion ctors.

Browse Source
This commit is contained in:
Neil MacIntosh 2016-03-16 19:39:55 -07:00
parent c40094a532
commit 717a2e35f1
2 changed files with 98 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

73
include/span.h
View File

@ -92,6 +92,53 @@ template <class T>
struct is_span : is_span_oracle<std::remove_cv_t<T>>
{
};
template <class From, class To>
struct is_allowed_pointer_conversion
: std::integral_constant<bool,
std::is_pointer<From>::value &&
std::is_pointer<To>::value &&
std::is_convertible<From, To>::value
>
{
};
template <class From, class To>
struct is_allowed_integral_conversion
: std::integral_constant<bool,
std::is_integral<From>::value &&
std::is_integral<To>::value &&
sizeof(From) == sizeof(To) &&
alignof(From) == alignof(To) &&
std::is_convertible<From, To>::value
>
{
};
template <class From, class To>
struct is_allowed_element_type_conversion
: std::integral_constant<bool,
std::is_same<From, std::remove_cv_t<To>>::value ||
is_allowed_pointer_conversion<From, To>::value ||
is_allowed_integral_conversion<From, To>::value
>
{
};
template <class From>
struct is_allowed_element_type_conversion<From, char>
: std::integral_constant<bool, !std::is_const<From>::value>
{
};
template <class From>
struct is_allowed_element_type_conversion<From, const char>
: std::integral_constant<bool, true>
{
};
} // namespace details
@ -163,13 +210,29 @@ public:
>
span(const Container&&) = delete;
#if 0 // TODO
constexpr span(const span& other) noexcept = default;
constexpr span(span&& other) noexcept = default;
template <class OtherElementType, ptrdiff_t OtherExtent>
constexpr span(const span<OtherElementType, OtherExtent>& other);
template <class OtherElementType, ptrdiff_t OtherExtent>
constexpr span(span<OtherElementType, OtherExtent>&& other);
template <class OtherElementType, std::ptrdiff_t OtherExtent,
class = std::enable_if_t<!std::is_same<element_type, OtherElementType>::value &&
details::is_allowed_element_type_conversion<OtherElementType, element_type>::value
>
>
constexpr span(const span<OtherElementType, OtherExtent>& other)
: storage_(reinterpret_cast<pointer>(other.data()), other.length())
{}
template <class OtherElementType, std::ptrdiff_t OtherExtent,
class = std::enable_if_t<!std::is_same<element_type, OtherElementType>::value &&
details::is_allowed_element_type_conversion<OtherElementType, element_type>::value
>
>
constexpr span(span<OtherElementType, OtherExtent>&& other)
: storage_(reinterpret_cast<pointer>(other.data()), other.length())
{
}
#if 0 // TODO
~span() noexcept = default;
constexpr span& operator=(const span& other) noexcept = default;
constexpr span& operator=(span&& other) noexcept = default;

52
tests/span_tests.cpp
View File

@ -512,34 +512,44 @@ SUITE(span_tests)
#endif
}
}
#if 0
TEST(from_convertible_span_constructor)
{
#ifdef CONFIRM_COMPILATION_ERRORS
span<int, 7, 4, 2> av1(nullptr, b1);
auto f = [&]() { span<int, 7, 4, 2> av1(nullptr); };
CHECK_THROW(f(), fail_fast);
#endif
#ifdef CONFIRM_COMPILATION_ERRORS
static_bounds<size_t, 7, dynamic_range, 2> b12(b11);
b12 = b11;
b11 = b12;
span<int, dynamic_range> av1 = nullptr;
span<int, 7, dynamic_range, 2> av2(av1);
span<int, 7, 4, 2> av2(av1);
#endif
{
span<DerivedClass> avd;
#ifdef CONFIRM_COMPILATION_ERRORS
span<BaseClass> avb = avd;
#endif
span<const DerivedClass> avcd = avd;
(void)avcd;
}
{
#ifdef CONFIRM_COMPILATION_ERRORS
span<DerivedClass> avd;
span<BaseClass> avb = avd;
(void) avb;
#endif
}
{
span<int> s;
span<unsigned int> s2 = s;
(void)s2;
}
{
span<int> s;
span<const unsigned int> s2 = s;
(void)s2;
}
{
#ifdef CONFIRM_COMPILATION_ERRORS
span<int> s;
span<short> s2 = s;
(void)s2;
#endif
}
}
#if 0
TEST(copy_move_and_assignment)
{
span<int> s1;