para/GSL
1
0
Fork 0
mirror of https://github.com/microsoft/GSL.git synced 2024-11-03 17:56:43 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Applying Casey's suggestions

Browse Source 
Applying @CaseyCarter's suggested forwarding changes
And adding `[[nodiscard]]` on `finally`

Thanks Casey -- somehow this slipped through the cracks for a year.
This commit is contained in:
Herb Sutter 2022-08-30 16:05:09 -07:00 committed by GitHub
parent 020ddc40c5
commit 6b284bf500
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
include/gsl/util
View File

@ -52,7 +52,9 @@ template <class F>
class final_action
{
public:
explicit final_action(F f_) : f(std::move(f_)) { }
template <class FF>
explicit final_action(FF&& ff) : f{std::forward<FF>(ff)} { }
~final_action() { if (invoke) f(); }
final_action(final_action&& other)
@ -60,8 +62,8 @@ public:
{ }
final_action(const final_action& rhs) = delete;
final_action& operator=(const final_action&) = delete;
final_action& operator=(final_action&& other) = delete;
void operator=(const final_action&) = delete;
void operator=(final_action&& other) = delete;
private:
F f;
@ -70,9 +72,9 @@ private:
// finally() - convenience function to generate a final_action
template <class F>
auto finally(F f) noexcept
[[nodiscard]] auto finally(F&& f) noexcept
{
return final_action<F>{f};
return final_action<F>{std::forward<F>(f)};
}
// narrow_cast(): a searchable way to do narrowing casts of values