para/GSL
1
0
Fork 0
mirror of https://github.com/microsoft/GSL.git synced 2024-11-03 17:56:43 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Silence warning in algorithm_tests with VS2017 (#453)

Browse Source 
Now that the STL respects /W4, this test that uses std::copy_n to copy a span of ints to a span of chars triggers "warning C4244: '=': conversion from 'int' to 'char', possible loss of data". Switch the source & destination spans to short and int to maintain the test's cross-type nature but without narrowing.
This commit is contained in:
Casey Carter 2017-02-13 11:25:09 -08:00 committed by Neil MacIntosh
parent 6360dd1e75
commit 6367b42ac5
1 changed files with 17 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
tests/algorithm_tests.cpp
View File

@ -100,11 +100,11 @@ SUITE(copy_tests)
{ {
// dynamic source and destination span // dynamic source and destination span
{ {
std::array<int, 5> src{1, 2, 3, 4, 5}; std::array<short, 5> src{1, 2, 3, 4, 5};
std::array<char, 10> dst{}; std::array<int, 10> dst{};
span<int> src_span(src); span<short> src_span(src);
span<char> dst_span(dst); span<int> dst_span(dst);
copy(src_span, dst_span); copy(src_span, dst_span);
copy(src_span, dst_span.subspan(src_span.size())); copy(src_span, dst_span.subspan(src_span.size()));
@ -117,11 +117,11 @@ SUITE(copy_tests)
// static source and dynamic destination span // static source and dynamic destination span
{ {
std::array<int, 5> src{1, 2, 3, 4, 5}; std::array<short, 5> src{1, 2, 3, 4, 5};
std::array<char, 10> dst{}; std::array<int, 10> dst{};
span<int, 5> src_span(src); span<short, 5> src_span(src);
span<char> dst_span(dst); span<int> dst_span(dst);
copy(src_span, dst_span); copy(src_span, dst_span);
copy(src_span, dst_span.subspan(src_span.size())); copy(src_span, dst_span.subspan(src_span.size()));
@ -134,11 +134,11 @@ SUITE(copy_tests)
// dynamic source and static destination span // dynamic source and static destination span
{ {
std::array<int, 5> src{1, 2, 3, 4, 5}; std::array<short, 5> src{1, 2, 3, 4, 5};
std::array<char, 10> dst{}; std::array<int, 10> dst{};
span<int> src_span(src); span<short> src_span(src);
span<char, 10> dst_span(dst); span<int, 10> dst_span(dst);
copy(src_span, dst_span); copy(src_span, dst_span);
copy(src_span, dst_span.subspan(src_span.size())); copy(src_span, dst_span.subspan(src_span.size()));
@ -151,11 +151,11 @@ SUITE(copy_tests)
// static source and destination span // static source and destination span
{ {
std::array<int, 5> src{1, 2, 3, 4, 5}; std::array<short, 5> src{1, 2, 3, 4, 5};
std::array<char, 10> dst{}; std::array<int, 10> dst{};
span<int, 5> src_span(src); span<short, 5> src_span(src);
span<char, 10> dst_span(dst); span<int, 10> dst_span(dst);
copy(src_span, dst_span); copy(src_span, dst_span);
copy(src_span, dst_span.subspan(src_span.size())); copy(src_span, dst_span.subspan(src_span.size()));
@ -206,4 +206,4 @@ SUITE(copy_tests)
} }
} }
int main(int, const char* []) { return UnitTest::RunAllTests(); } int main() { return UnitTest::RunAllTests(); }