para/GSL
1
0
Fork 0
mirror of https://github.com/microsoft/GSL.git synced 2024-11-03 17:56:43 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Use the implementation-defined strict total order for pointer comparisons with not_null (#1106)

Browse Source 
Using `<`,`<=`,`>`,`>=` to compare unrelated pointers gives an unspecified result according to the standard.
This PR replaces the usage of these operators in `gsl::not_null` with the STL counterparts, which would leverage any implementation-defined strict total ordering for pointers.

Resolves #880
This commit is contained in:
Dmitry Kobets 2023-05-09 09:06:53 -07:00 committed by GitHub
parent 9face82309
commit 5dc7fae119
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
include/gsl/pointers
View File

@ -175,34 +175,34 @@ auto operator!=(const not_null<T>& lhs,
template <class T, class U> template <class T, class U>
auto operator<(const not_null<T>& lhs, auto operator<(const not_null<T>& lhs,
const not_null<U>& rhs) noexcept(noexcept(lhs.get() < rhs.get())) const not_null<U>& rhs) noexcept(noexcept(std::less<>{}(lhs.get(), rhs.get())))
-> decltype(lhs.get() < rhs.get()) -> decltype(std::less<>{}(lhs.get(), rhs.get()))
{ {
return lhs.get() < rhs.get(); return std::less<>{}(lhs.get(), rhs.get());
} }
template <class T, class U> template <class T, class U>
auto operator<=(const not_null<T>& lhs, auto operator<=(const not_null<T>& lhs,
const not_null<U>& rhs) noexcept(noexcept(lhs.get() <= rhs.get())) const not_null<U>& rhs) noexcept(noexcept(std::less_equal<>{}(lhs.get(), rhs.get())))
-> decltype(lhs.get() <= rhs.get()) -> decltype(std::less_equal<>{}(lhs.get(), rhs.get()))
{ {
return lhs.get() <= rhs.get(); return std::less_equal<>{}(lhs.get(), rhs.get());
} }
template <class T, class U> template <class T, class U>
auto operator>(const not_null<T>& lhs, auto operator>(const not_null<T>& lhs,
const not_null<U>& rhs) noexcept(noexcept(lhs.get() > rhs.get())) const not_null<U>& rhs) noexcept(noexcept(std::greater<>{}(lhs.get(), rhs.get())))
-> decltype(lhs.get() > rhs.get()) -> decltype(std::greater<>{}(lhs.get(), rhs.get()))
{ {
return lhs.get() > rhs.get(); return std::greater<>{}(lhs.get(), rhs.get());
} }
template <class T, class U> template <class T, class U>
auto operator>=(const not_null<T>& lhs, auto operator>=(const not_null<T>& lhs,
const not_null<U>& rhs) noexcept(noexcept(lhs.get() >= rhs.get())) const not_null<U>& rhs) noexcept(noexcept(std::greater_equal<>{}(lhs.get(), rhs.get())))
-> decltype(lhs.get() >= rhs.get()) -> decltype(std::greater_equal<>{}(lhs.get(), rhs.get()))
{ {
return lhs.get() >= rhs.get(); return std::greater_equal<>{}(lhs.get(), rhs.get());
} }
// more unwanted operators // more unwanted operators