diff --git a/gsl/gsl_byte b/gsl/gsl_byte index 98749a7..c973320 100644 --- a/gsl/gsl_byte +++ b/gsl/gsl_byte @@ -106,11 +106,33 @@ constexpr IntegerType to_integer(byte b) noexcept return {b}; } -constexpr byte to_byte(unsigned char i) noexcept +template +constexpr byte to_byte_impl(T t) noexcept { - return static_cast(i); + static_assert( + false, + "gsl::to_byte(t) must be provided an unsigned char, otherwise data loss may occur. " + "If you are calling to_byte with an integer contant use: gsl::to_byte() version." + ) +} +template<> +constexpr byte to_byte_impl(unsigned char t) noexcept +{ + return byte(t); } +template +constexpr byte to_byte(T t) noexcept +{ + return to_byte_impl::value, T>(t); +} + +template +constexpr byte to_byte() noexcept +{ + static_assert(I >= 0 && I <= 255, "gsl::byte only has 8 bits of storage, values must be in range 0-255"); + return static_cast(I); +} } // namespace gsl diff --git a/tests/byte_tests.cpp b/tests/byte_tests.cpp index d6d4823..59ff0cd 100644 --- a/tests/byte_tests.cpp +++ b/tests/byte_tests.cpp @@ -45,7 +45,12 @@ SUITE(byte_tests) } { - byte b = to_byte(12); + byte b = to_byte<12>(); + CHECK(static_cast(b) == 12); + } + { + unsigned char uc = 12; + byte b = to_byte(uc); CHECK(static_cast(b) == 12); } @@ -58,38 +63,38 @@ SUITE(byte_tests) TEST(bitwise_operations) { - byte b = to_byte(0xFF); + byte b = to_byte<0xFF>(); - byte a = to_byte(0x00); - CHECK((b | a) == to_byte(0xFF)); - CHECK(a == to_byte(0x00)); + byte a = to_byte<0x00>(); + CHECK((b | a) == to_byte<0xFF>()); + CHECK(a == to_byte<0x00>()); a |= b; - CHECK(a == to_byte(0xFF)); + CHECK(a == to_byte<0xFF>()); - a = to_byte(0x01); - CHECK((b & a) == to_byte(0x01)); + a = to_byte<0x01>(); + CHECK((b & a) == to_byte<0x01>()); a &= b; - CHECK(a == to_byte(0x01)); + CHECK(a == to_byte<0x01>()); - CHECK((b ^ a) == to_byte(0xFE)); + CHECK((b ^ a) == to_byte<0xFE>()); - CHECK(a == to_byte(0x01)); + CHECK(a == to_byte<0x01>()); a ^= b; - CHECK(a == to_byte(0xFE)); + CHECK(a == to_byte<0xFE>()); - a = to_byte(0x01); - CHECK(~a == to_byte(0xFE)); + a = to_byte<0x01>(); + CHECK(~a == to_byte<0xFE>()); - a = to_byte(0xFF); - CHECK((a << 4) == to_byte(0xF0)); - CHECK((a >> 4) == to_byte(0x0F)); + a = to_byte<0xFF>(); + CHECK((a << 4) == to_byte<0xF0>()); + CHECK((a >> 4) == to_byte<0x0F>()); a <<= 4; - CHECK(a == to_byte(0xF0)); + CHECK(a == to_byte<0xF0>()); a >>= 4; - CHECK(a == to_byte(0x0F)); + CHECK(a == to_byte<0x0F>()); } }