para/GSL
1
0
Fork 0
mirror of https://github.com/microsoft/GSL.git synced 2024-11-03 17:56:43 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

added additional filtering to Apple clang versions 9.4 and 10.1 for the ArrayConvertibilityCheck

Browse Source
This commit is contained in:
Jordan Maples 2020-04-09 10:34:58 -07:00
parent f85166aa8b
commit 2f9d873043
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tests/span_compatibility_tests.cpp
View File

@ -42,7 +42,14 @@ static_assert(std::is_convertible<Derived*, Base*>::value, "std::is_convertible<
static_assert(!std::is_convertible<Derived (*)[], Base (*)[]>::value,
"!std::is_convertible<Derived(*)[], Base(*)[]>");
#if (defined(_MSC_VER)) || (defined(__GNUC__) && __GNUC__ > 7) || (defined(__clang__) && __clang_major__ > 6)
// int*(*) [], int const* const(*)[] was identified as an issue in CWG330 and the resolution was provided with N4261
// The changes were not backported to all versions of the compilers that GSL supports.
// The `if constexpr` should prevent codegen from happening if it is not supported however a few compilers continue to complain about the logic within.
// Filtering g++ version < 8, clang version < 7, and Apple clang versions 9.4 and 10.1.
#if (defined(_MSC_VER)) || \
(defined(__GNUC__) && __GNUC__ > 7) || \
(defined(__APPLE__) && defined(__clang__) && (!(__clang_major__ == 9 && __clang_minor == 4) && !(__clang_major__ == 10 && __clang_minro__ == 1))) || \
(defined(__clang__) && __clang_major__ > 6)
template <class = void>
void ArrayConvertibilityCheck()
{