From 2a1ef2540687efcf1a62c8213404b242e792bff3 Mon Sep 17 00:00:00 2001 From: JACK_1729 Date: Wed, 20 Feb 2019 20:25:50 +0530 Subject: [PATCH 1/4] Update span About my Issue - https://github.com/Microsoft/GSL/issues/765 --- include/gsl/span | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/gsl/span b/include/gsl/span index b4da532..59bd121 100644 --- a/include/gsl/span +++ b/include/gsl/span @@ -141,7 +141,7 @@ namespace details span_iterator() = default; - constexpr span_iterator(const Span* span, typename Span::index_type idx) noexcept + constexpr span_iterator(const Span* span, difference_type idx) noexcept : span_(span), index_(idx) {} From b05a4464b90d8faf8528ec2c6185c02a0ac93b1f Mon Sep 17 00:00:00 2001 From: Eyal Rozenberg Date: Mon, 5 Aug 2019 13:16:42 +0300 Subject: [PATCH 2/4] Fixes #798 : Dropped inclusion of `gsl/pointers` in `string_span`. --- include/gsl/string_span | 1 - 1 file changed, 1 deletion(-) diff --git a/include/gsl/string_span b/include/gsl/string_span index 85112e5..37cbe15 100644 --- a/include/gsl/string_span +++ b/include/gsl/string_span @@ -20,7 +20,6 @@ #include // for Ensures, Expects #include // for narrow_cast #include // for operator!=, operator==, dynamic_extent -#include // for not_null #include // for equal, lexicographical_compare #include // for array From 1d48188de9e979a27f29286d76bb0622323a8952 Mon Sep 17 00:00:00 2001 From: beinhaerter <34543625+beinhaerter@users.noreply.github.com> Date: Wed, 14 Aug 2019 21:40:35 +0200 Subject: [PATCH 3/4] Fixed check if std::byte is available (#764) The check for std::byte existance fails on gcc 8.2. According to https://en.cppreference.com/w/cpp/utility/feature_test it is necessary to `#include ` before checking `__cpp_lib_byte`. --- include/gsl/gsl_byte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/gsl/gsl_byte b/include/gsl/gsl_byte index 861446d..1670646 100644 --- a/include/gsl/gsl_byte +++ b/include/gsl/gsl_byte @@ -56,6 +56,7 @@ #else // _MSC_VER #ifndef GSL_USE_STD_BYTE +#include /* __cpp_lib_byte */ // this tests if we are under GCC or Clang with enough -std:c++1z power to get us std::byte // also check if libc++ version is sufficient (> 5.0) or libstc++ actually contains std::byte #if defined(__cplusplus) && (__cplusplus >= 201703L) && \ @@ -63,7 +64,6 @@ defined(_LIBCPP_VERSION) && (_LIBCPP_VERSION >= 5000)) #define GSL_USE_STD_BYTE 1 -#include #else // defined(__cplusplus) && (__cplusplus >= 201703L) && // (defined(__cpp_lib_byte) && (__cpp_lib_byte >= 201603) || From cee1929de77eb2fa22bb329900f6ce00be9f6e82 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Johel=20Ernesto=20Guerrero=20Pe=C3=B1a?= Date: Wed, 14 Aug 2019 15:56:53 -0400 Subject: [PATCH 4/4] Fix GNUC typo (#780) Resolves #779 --- include/gsl/gsl_util | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/gsl/gsl_util b/include/gsl/gsl_util index 4addde6..0fce689 100644 --- a/include/gsl/gsl_util +++ b/include/gsl/gsl_util @@ -37,7 +37,7 @@ #endif // _MSC_VER < 1910 #endif // _MSC_VER -#if (defined(_MSC_VER) && _MSC_VER < 1910) || (!defined(__clang__) && defined(__GNUC__) && __GUNC__ < 6) +#if (defined(_MSC_VER) && _MSC_VER < 1910) || (!defined(__clang__) && defined(__GNUC__) && __GNUC__ < 6) #define GSL_CONSTEXPR_NARROW 0 #else #define GSL_CONSTEXPR_NARROW 1