para/GSL
1
0
Fork 0
mirror of https://github.com/microsoft/GSL.git synced 2025-02-20 08:28:09 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Delete the useless 'noexcept(false)'

Browse Source
This commit is contained in:
归故里 2024-05-15 10:34:53 +08:00
parent b39e7e4b09
commit 065c1dc2d7
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
include/gsl/narrow
View File

@ -30,13 +30,12 @@ struct narrowing_error : public std::exception
template <class T, class U, typename std::enable_if<std::is_arithmetic<T>::value>::type* = nullptr> template <class T, class U, typename std::enable_if<std::is_arithmetic<T>::value>::type* = nullptr>
// clang-format off // clang-format off
GSL_SUPPRESS(type.1) // NO-FORMAT: attribute GSL_SUPPRESS(type.1) // NO-FORMAT: attribute
GSL_SUPPRESS(f.6) // NO-FORMAT: attribute // TODO: MSVC /analyze does not recognise noexcept(false)
GSL_SUPPRESS(es.46) // NO-FORMAT: attribute // The warning suggests that a floating->unsigned conversion can occur GSL_SUPPRESS(es.46) // NO-FORMAT: attribute // The warning suggests that a floating->unsigned conversion can occur
// in the static_cast below, and that gsl::narrow should be used instead. // in the static_cast below, and that gsl::narrow should be used instead.
// Suppress this warning, since gsl::narrow is defined in terms of // Suppress this warning, since gsl::narrow is defined in terms of
// static_cast // static_cast
// clang-format on // clang-format on
constexpr T narrow(U u) noexcept(false) constexpr T narrow(U u)
{ {
constexpr const bool is_different_signedness = constexpr const bool is_different_signedness =
(std::is_signed<T>::value != std::is_signed<U>::value); (std::is_signed<T>::value != std::is_signed<U>::value);
@ -67,9 +66,8 @@ GSL_SUPPRESS(p.2) // NO-FORMAT: attribute // don't rely on undefined behavior
template <class T, class U, typename std::enable_if<!std::is_arithmetic<T>::value>::type* = nullptr> template <class T, class U, typename std::enable_if<!std::is_arithmetic<T>::value>::type* = nullptr>
// clang-format off // clang-format off
GSL_SUPPRESS(type.1) // NO-FORMAT: attribute GSL_SUPPRESS(type.1) // NO-FORMAT: attribute
GSL_SUPPRESS(f.6) // NO-FORMAT: attribute // TODO: MSVC /analyze does not recognise noexcept(false)
// clang-format on // clang-format on
constexpr T narrow(U u) noexcept(false) constexpr T narrow(U u)
{ {
const T t = narrow_cast<T>(u); const T t = narrow_cast<T>(u);