From 5d1c0f7a59b28320414781fbc4dd2a4642116750 Mon Sep 17 00:00:00 2001 From: Edo Date: Fri, 5 May 2023 09:12:08 +0100 Subject: [PATCH] maint(cryptography): reduce code generation by at least 3 asm instructions MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 😱 --- src/common/utils/cryptography.cpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/common/utils/cryptography.cpp b/src/common/utils/cryptography.cpp index 1b5e7a12..625403fb 100644 --- a/src/common/utils/cryptography.cpp +++ b/src/common/utils/cryptography.cpp @@ -240,7 +240,7 @@ namespace utils::cryptography return {cs(buffer), length}; } - return ""; + return {}; } std::string ecc::key::get_openssl() const @@ -253,7 +253,7 @@ namespace utils::cryptography return {cs(buffer), length}; } - return ""; + return {}; } void ecc::key::set_openssl(const std::string& key) @@ -313,7 +313,7 @@ namespace utils::cryptography std::string ecc::sign_message(const key& key, const std::string& message) { - if (!key.is_valid()) return ""; + if (!key.is_valid()) return {}; uint8_t buffer[512]; unsigned long length = sizeof(buffer); @@ -408,7 +408,6 @@ namespace utils::cryptography rsa_free(&new_key); }); - std::string out_data{}; out_data.resize(std::max(ul(data.size() * 3), ul(0x100)));