maint(compression): pass args by reference

Co-authored-by: William Roy <wroy@proton.me>

src/main.cpp

@@ -35,7 +35,7 @@ int main(const int argc, const char** argv)
 
 	try
 	{
-		unsafe_main(argc > 1 ? static_cast<uint16_t>(atoi(argv[1])) : 20810);
+		unsafe_main(argc > 1 ? static_cast<uint16_t>(std::strtol(argv[1], nullptr, 10)) : 20810);
 	}
 	catch (std::exception& e)
 	{

src/utils/compression.cpp

@@ -134,9 +134,9 @@ namespace utils::compression
 			}
 		}
 
-		void archive::add(std::string filename, std::string data)
+		void archive::add(const std::string& filename, const std::string& data)
 		{
-			this->files_[std::move(filename)] = std::move(data);
+			this->files_[filename] = data;
 		}
 
 		bool archive::write(const std::string& filename, const std::string& comment)

src/utils/compression.hpp

@@ -18,7 +18,7 @@ namespace utils::compression
 		class archive
 		{
 		public:
-			void add(std::string filename, std::string data);
+			void add(const std::string& filename, const std::string& data);
 			bool write(const std::string& filename, const std::string& comment = {});
 
 		private: