From ddce60ee00cc159d96d64346d87dc693cc6a3787 Mon Sep 17 00:00:00 2001 From: /dev/root Date: Mon, 21 Nov 2016 20:49:33 +0100 Subject: [PATCH] [Cache] Removed Constructor - removed Constructor - changed all functions to static [ci skip] --- src/Components/Modules/Maps.cpp | 16 +++++++-------- src/Components/Modules/News.cpp | 8 ++++---- src/Components/Modules/Node.cpp | 2 +- src/Utils/Cache.cpp | 36 ++++++++++++++++----------------- src/Utils/Cache.hpp | 12 +++++------ 5 files changed, 36 insertions(+), 38 deletions(-) diff --git a/src/Components/Modules/Maps.cpp b/src/Components/Modules/Maps.cpp index 86b46696..d7a3e0e8 100644 --- a/src/Components/Modules/Maps.cpp +++ b/src/Components/Modules/Maps.cpp @@ -492,14 +492,14 @@ namespace Components { Dvar::Register("isDlcInstalled_All", false, Game::DVAR_FLAG_USERCREATED | Game::DVAR_FLAG_WRITEPROTECTED, ""); - Maps::AddDlc({ 1, Utils::Cache("/dlc/IW4.DLC.1.Stimulus.Package.zip").GetUrl(), { "mp_complex", "mp_compact", "mp_storm", "mp_overgrown", "mp_crash" } }); - Maps::AddDlc({ 2, Utils::Cache("/dlc/IW4.DLC.2.Resurgence.Pack.zip").GetUrl(), { "mp_abandon", "mp_vacant", "mp_trailerpark", "mp_strike", "mp_fuel2" } }); - Maps::AddDlc({ 3, Utils::Cache("/dlc/IW4.DLC.3.Nuketown.zip").GetUrl(), { "mp_nuked" } }); - Maps::AddDlc({ 4, Utils::Cache("/dlc/IW4.DLC.4.Classics.1.zip").GetUrl(), { "mp_cross_fire", "mp_cargoship", "mp_bloc" } }); - Maps::AddDlc({ 5, Utils::Cache("/dlc/IW4.DLC.5.Classics.2.zip").GetUrl(), { "mp_killhouse", "mp_bog_sh" } }); - Maps::AddDlc({ 6, Utils::Cache("/dlc/IW4.DLC.6.Cargoship.Winter.zip").GetUrl(), { "mp_cargoship_sh" } }); - Maps::AddDlc({ 7, Utils::Cache("/dlc/IW4.DLC.7.Resurrection.Pack.zip").GetUrl(), { "mp_shipment_long", "mp_rust_long", "mp_firingrange" } }); - Maps::AddDlc({ 8, ""/*Utils::Cache("/dlc/").GetUrl()*/,{ /*"mp_bloc_sh", "mp_crash_tropical", "mp_estate_tropical", "mp_fav_tropical", "mp_storm_spring"*/ } }); + Maps::AddDlc({ 1, Utils::Cache::GetUrl("/dlc/IW4.DLC.1.Stimulus.Package.zip"), { "mp_complex", "mp_compact", "mp_storm", "mp_overgrown", "mp_crash" } }); + Maps::AddDlc({ 2, Utils::Cache::GetUrl("/dlc/IW4.DLC.2.Resurgence.Pack.zip"), { "mp_abandon", "mp_vacant", "mp_trailerpark", "mp_strike", "mp_fuel2" } }); + Maps::AddDlc({ 3, Utils::Cache::GetUrl("/dlc/IW4.DLC.3.Nuketown.zip"), { "mp_nuked" } }); + Maps::AddDlc({ 4, Utils::Cache::GetUrl("/dlc/IW4.DLC.4.Classics.1.zip"), { "mp_cross_fire", "mp_cargoship", "mp_bloc" } }); + Maps::AddDlc({ 5, Utils::Cache::GetUrl("/dlc/IW4.DLC.5.Classics.2.zip"), { "mp_killhouse", "mp_bog_sh" } }); + Maps::AddDlc({ 6, Utils::Cache::GetUrl("/dlc/IW4.DLC.6.Cargoship.Winter.zip"), { "mp_cargoship_sh" } }); + Maps::AddDlc({ 7, Utils::Cache::GetUrl("/dlc/IW4.DLC.7.Resurrection.Pack.zip"), { "mp_shipment_long", "mp_rust_long", "mp_firingrange" } }); + Maps::AddDlc({ 8, ""/*Utils::Cache::GetUrl("/dlc/")*/,{ /*"mp_bloc_sh", "mp_crash_tropical", "mp_estate_tropical", "mp_fav_tropical", "mp_storm_spring"*/ } }); Maps::UpdateDlcStatus(); diff --git a/src/Components/Modules/News.cpp b/src/Components/Modules/News.cpp index be18f568..c5f1a86f 100644 --- a/src/Components/Modules/News.cpp +++ b/src/Components/Modules/News.cpp @@ -73,7 +73,7 @@ namespace Components void News::CheckForUpdate() { - std::string caches = Utils::Cache("/iw4/caches.xml").GetFile(); + std::string caches = Utils::Cache::GetFile("/iw4/caches.xml"); if (!caches.empty()) { @@ -134,7 +134,7 @@ namespace Components std::thread([] () { - std::string data = Utils::Cache("/iw4/updater.exe").GetFile(); + std::string data = Utils::Cache::GetFile("/iw4/updater.exe"); if (data.empty()) { @@ -156,9 +156,9 @@ namespace Components News::Terminate = false; News::Thread = std::thread([] () { - Localization::Set("MPUI_CHANGELOG_TEXT", Utils::Cache("/iw4/changelog.txt").GetFile()); + Localization::Set("MPUI_CHANGELOG_TEXT", Utils::Cache::GetFile("/iw4/changelog.txt")); - std::string data = Utils::Cache("/iw4/motd.txt").GetFile(); + std::string data = Utils::Cache::GetFile("/iw4/motd.txt"); if (!data.empty()) { diff --git a/src/Components/Modules/Node.cpp b/src/Components/Modules/Node.cpp index 9d209e62..bd77ef0c 100644 --- a/src/Components/Modules/Node.cpp +++ b/src/Components/Modules/Node.cpp @@ -10,7 +10,7 @@ namespace Components void Node::LoadNodeRemotePreset() { - std::string nodes = Utils::Cache("/iw4/nodes.txt").GetFile(); + std::string nodes = Utils::Cache::GetFile("/iw4/nodes.txt"); if (nodes.empty()) return; auto nodeList = Utils::String::Explode(nodes, '\n'); diff --git a/src/Utils/Cache.cpp b/src/Utils/Cache.cpp index 0fc1c391..f3d6c4aa 100644 --- a/src/Utils/Cache.cpp +++ b/src/Utils/Cache.cpp @@ -2,27 +2,24 @@ namespace Utils { - const char* Cache::urls[] = + const char* Cache::Urls[] = { "https://iw4xcachep26muba.onion.to"/*, "https://iw4xcachejnetuln.onion.to", "https://iw4xcachedjodc4y.onion.to", */ }; - std::string Cache::validUrl; + std::string Cache::ValidUrl; std::mutex Cache::CacheMutex; - Cache::Cache(std::string path) + std::string Cache::GetUrl(std::string path) { - this->Path = path; - } + std::lock_guard _(Cache::CacheMutex); - std::string Cache::GetUrl() - { - if (Cache::validUrl.empty()) - return Cache::urls[0] + this->Path; + if (Cache::ValidUrl.empty()) + return Cache::Urls[0] + path; else - return Cache::validUrl + this->Path; + return Cache::ValidUrl + path; } std::string Cache::GetUrl(std::string url, std::string path) @@ -30,25 +27,28 @@ namespace Utils return url + path; } - std::string Cache::GetFile(int timeout, std::string useragent) + std::string Cache::GetFile(std::string path, int timeout, std::string useragent) { - if (Cache::validUrl.empty()) + std::lock_guard _(Cache::CacheMutex); + + if (Cache::ValidUrl.empty()) { - std::lock_guard _(Cache::CacheMutex); - for (int i = 0; i < ARRAY_SIZE(Cache::urls); i++) + for (int i = 0; i < ARRAY_SIZE(Cache::Urls); i++) { - std::string result = Utils::WebIO(useragent, this->GetUrl(Cache::urls[i], this->Path)).setTimeout(timeout)->get(); + std::string result = Utils::WebIO(useragent, Cache::GetUrl(Cache::Urls[i], path)).setTimeout(timeout)->get(); + if (!result.empty()) { - Cache::validUrl = Cache::urls[i]; + Cache::ValidUrl = Cache::Urls[i]; return result; } } + + return ""; } else { - return Utils::WebIO(useragent, this->GetUrl(Cache::validUrl, this->Path)).setTimeout(timeout)->get(); + return Utils::WebIO(useragent, Cache::GetUrl(Cache::ValidUrl, path)).setTimeout(timeout)->get(); } - return ""; } } diff --git a/src/Utils/Cache.hpp b/src/Utils/Cache.hpp index bc2e6090..0d97fe3e 100644 --- a/src/Utils/Cache.hpp +++ b/src/Utils/Cache.hpp @@ -3,15 +3,13 @@ namespace Utils class Cache { public: - Cache(std::string path); - std::string GetUrl(); - std::string GetFile(int timeout = 5000, std::string useragent = "IW4x"); + static std::string GetUrl(std::string path); + static std::string GetFile(std::string path, int timeout = 5000, std::string useragent = "IW4x"); private: static std::mutex CacheMutex; - static const char* urls[]; - static std::string validUrl; - std::string Path; - std::string GetUrl(std::string url, std::string path); + static const char* Urls[]; + static std::string ValidUrl; + static std::string GetUrl(std::string url, std::string path); }; }