From 531fdf0e348239908ec88e49934b137daa2ccc4a Mon Sep 17 00:00:00 2001 From: /dev/urandom Date: Sun, 28 Aug 2016 22:47:22 +0200 Subject: [PATCH] Fix crash if a valid minidump is residing in minidumps folder. --- src/Components/Modules/MinidumpUpload.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Components/Modules/MinidumpUpload.cpp b/src/Components/Modules/MinidumpUpload.cpp index 1fbef281..3554f2a9 100644 --- a/src/Components/Modules/MinidumpUpload.cpp +++ b/src/Components/Modules/MinidumpUpload.cpp @@ -26,7 +26,7 @@ namespace Components std::string Minidump::ToString() { - if (!Minidump::EnsureFileMapping()) return false; + if (!this->EnsureFileMapping()) return false; auto pBuf = MapViewOfFile(this->mapFileHandle, FILE_MAP_READ, 0, 0, 0); if (pBuf == NULL) @@ -48,7 +48,7 @@ namespace Components bool Minidump::GetStream(MINIDUMP_STREAM_TYPE type, PMINIDUMP_DIRECTORY* directoryPtr, PVOID* streamBeginningPtr, ULONG* streamSizePtr) { - if (!Minidump::EnsureFileMapping()) return false; + if (!this->EnsureFileMapping()) return false; auto pBuf = MapViewOfFile(this->mapFileHandle, FILE_MAP_READ, 0, 0, 0); if (pBuf == NULL) @@ -110,7 +110,7 @@ namespace Components if (this->mapFileHandle == NULL || this->mapFileHandle == INVALID_HANDLE_VALUE) { this->mapFileHandle = CreateFileMappingA(this->fileHandle, NULL, PAGE_READONLY, 0, 0, NULL); - if (this->mapFileHandle == NULL || this->mapFileHandle == INVALID_HANDLE_VALUE) + if (this->mapFileHandle == NULL) { Utils::OutputDebugLastError(); return false;