Rim/iw4x-client
Rim/iw4x-client
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

Fix stack overflow in zlib decompress routine.

Browse Source
This commit is contained in:
momo5502 2016-01-09 16:02:54 +01:00
parent 7974bd5cd0
commit 4a0c4ec609
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/Utils/Compression.cpp
View File

@ -50,11 +50,11 @@ namespace Utils
if (inflateInit(&stream) != Z_OK) if (inflateInit(&stream) != Z_OK)
{ {
return buffer; return "";
} }
int ret = 0; int ret = 0;
uint8_t dest[CHUNK] = { 0 }; uint8_t* dest = new uint8_t[CHUNK];
const char* dataPtr = data.data(); const char* dataPtr = data.data();
do do
@ -71,6 +71,8 @@ namespace Utils
if (ret == Z_STREAM_ERROR) if (ret == Z_STREAM_ERROR)
{ {
inflateEnd(&stream); inflateEnd(&stream);
delete[] dest;
return "";
} }
buffer.append(reinterpret_cast<const char*>(dest), CHUNK - stream.avail_out); buffer.append(reinterpret_cast<const char*>(dest), CHUNK - stream.avail_out);
@ -81,6 +83,8 @@ namespace Utils
inflateEnd(&stream); inflateEnd(&stream);
delete[] dest;
return buffer; return buffer;
} }
}; };