Rim/h2-mod
Rim/h2-mod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

remove undefined behaviour from string util

Browse Source
This commit is contained in:
Diavolo 2022-09-06 17:51:40 +02:00
parent d45efeee08
commit f129e137fa
No known key found for this signature in database
GPG Key ID: FA77F074E98D98A5
1 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/common/utils/string.cpp
View File

@ -36,9 +36,9 @@ namespace utils::string
std::string to_lower(std::string text) std::string to_lower(std::string text)
{ {
std::transform(text.begin(), text.end(), text.begin(), [](const char input) std::transform(text.begin(), text.end(), text.begin(), [](const unsigned char input)
{ {
return static_cast<char>(tolower(input)); return static_cast<char>(std::tolower(input));
}); });
return text; return text;
@ -46,9 +46,9 @@ namespace utils::string
std::string to_upper(std::string text) std::string to_upper(std::string text)
{ {
std::transform(text.begin(), text.end(), text.begin(), [](const char input) std::transform(text.begin(), text.end(), text.begin(), [](const unsigned char input)
{ {
return static_cast<char>(toupper(input)); return static_cast<char>(std::toupper(input));
}); });
return text; return text;
@ -147,8 +147,6 @@ namespace utils::string
*out = '\0'; *out = '\0';
} }
#pragma warning(push)
#pragma warning(disable: 4100)
std::string convert(const std::wstring& wstr) std::string convert(const std::wstring& wstr)
{ {
std::string result; std::string result;
@ -174,7 +172,6 @@ namespace utils::string
return result; return result;
} }
#pragma warning(pop)
std::string replace(std::string str, const std::string& from, const std::string& to) std::string replace(std::string str, const std::string& from, const std::string& to)
{ {