From d61c73a5dd822018849e1f5e9ee34167013b2e8c Mon Sep 17 00:00:00 2001
From: Federico Cecchetto <fedecek3@gmail.com>
Date: Sat, 25 Jun 2022 18:36:23 +0200
Subject: [PATCH] Always show updater errors

---
 src/client/component/updater.cpp            | 3 ++-
 src/client/resources/ui_scripts/updater.lua | 5 -----
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/src/client/component/updater.cpp b/src/client/component/updater.cpp
index 44d2b611..ab2c748a 100644
--- a/src/client/component/updater.cpp
+++ b/src/client/component/updater.cpp
@@ -27,6 +27,7 @@
 #define DATA_PATH_DEV "data-dev/"
 
 #define ERR_UPDATE_CHECK_FAIL "Failed to check for updates"
+#define ERR_UPDATE_CHECK_FAIL_BAD_RESPONSE "Bad response"
 #define ERR_DOWNLOAD_FAIL "Failed to download file "
 #define ERR_WRITE_FAIL "Failed to write file "
 
@@ -345,7 +346,7 @@ namespace updater
 
 			if (!j.IsArray())
 			{
-				set_update_check_status(true, false, ERR_UPDATE_CHECK_FAIL);
+				set_update_check_status(true, false, ERR_UPDATE_CHECK_FAIL_BAD_RESPONSE);
 				return;
 			}
 
diff --git a/src/client/resources/ui_scripts/updater.lua b/src/client/resources/ui_scripts/updater.lua
index 90008700..5054cd74 100644
--- a/src/client/resources/ui_scripts/updater.lua
+++ b/src/client/resources/ui_scripts/updater.lua
@@ -12,11 +12,6 @@ function startupdatecheck(popup, autoclose)
 		end
 
 		if (not updater.getupdatecheckstatus()) then
-			if (autoclose) then
-				LUI.FlowManager.RequestLeaveMenu(popup)
-				return
-			end
-
 			popup.text:setText("Error: " .. updater.getlasterror())
 			return
 		end