From 840ac74ece4921e60eed90e569ffa324b68f335d Mon Sep 17 00:00:00 2001
From: faroukbmiled <fcfaroukfc@gmail.com>
Date: Fri, 29 Sep 2023 16:30:11 +0100
Subject: [PATCH] the right way to check fod updates ,down from 18 seconds to
 ~3 seconds (40 items)

---
 boiiiwd_package/src/helpers.py     | 30 +++++++++++++++++--------
 boiiiwd_package/src/library_tab.py | 35 +++++++++++++++---------------
 2 files changed, 38 insertions(+), 27 deletions(-)

diff --git a/boiiiwd_package/src/helpers.py b/boiiiwd_package/src/helpers.py
index 58def21..fc83b0f 100644
--- a/boiiiwd_package/src/helpers.py
+++ b/boiiiwd_package/src/helpers.py
@@ -351,11 +351,9 @@ def check_item_date(down_date, date_updated):
         except ValueError:
             download_datetime = datetime.strptime(down_date + f", {current_year}", date_format_with_added_year)
 
-        date_updated_datetime = datetime.fromtimestamp(date_updated)
-
-        if date_updated_datetime >= download_datetime:
+        if date_updated >= download_datetime:
             return True
-        elif date_updated_datetime < download_datetime:
+        elif date_updated < download_datetime:
             return False
     except:
         return False
@@ -395,11 +393,25 @@ def item_steam_api(id):
         print(e)
         return False
 
-def get_item_date(data):
+def get_item_dates(ids):
     try:
-        time_updated = data["response"]["publishedfiledetails"][0]["time_updated"]
-        return time_updated
-    except:
-        return None
+        data = {
+            "itemcount": len(ids),
+        }
+        for i, id in enumerate(ids):
+            data[f"publishedfileids[{i}]"] = int(id)
+
+        info = requests.post(ITEM_INFO_API, data=data)
+        response_data = info.json()
+
+        if "response" in response_data:
+            item_details = response_data["response"]["publishedfiledetails"]
+            return {item["publishedfileid"]: item["time_updated"] for item in item_details}
+
+        return {}
+
+    except Exception as e:
+        print(e)
+        return {}
 
 # End helper functions
diff --git a/boiiiwd_package/src/library_tab.py b/boiiiwd_package/src/library_tab.py
index 8b83823..f476586 100644
--- a/boiiiwd_package/src/library_tab.py
+++ b/boiiiwd_package/src/library_tab.py
@@ -849,41 +849,40 @@ class LibraryTab(ctk.CTkScrollableFrame):
         # Needed to refresh item that needs updates
         self.to_update.clear()
 
-        def if_id_needs_update(item_id, item_date, text):
+        def if_ids_need_update(item_ids, item_dates, texts):
             try:
-                item_data = item_steam_api(item_id)
-                date_updated = get_item_date(item_data)
+                item_data = get_item_dates(item_ids)
 
-                if not date_updated:
-                    return False
+                for item_id, date_updated in item_data.items():
+                    item_date = item_dates[item_id]
+                    date_updated = datetime.fromtimestamp(date_updated)
 
-                if check_item_date(item_date, date_updated):
-                    self.to_update.add(text + f" | Updated: {date_updated}")
-                    return True
-                else:
-                    return False
+                    if check_item_date(item_date, date_updated):
+                        date_updated = date_updated.strftime("%d %b @ %I:%M%p, %Y")
+                        self.to_update.add(texts[item_id] + f" | Updated: {date_updated}")
 
             except Exception as e:
-                show_message("Error", f"Error occured\n{e}", icon="cancel")
-                return
+                show_message("Error", f"Error occurred\n{e}", icon="cancel")
 
         def check_for_update():
             try:
                 lib_data = None
 
                 if not os.path.exists(os.path.join(application_path, LIBRARY_FILE)):
-                    show_message("Error checking for item updates! -> Setting is on", "Please visit library tab at least once with the correct boiii path!, you also need to have at lease 1 item!")
+                    show_message("Error checking for item updates! -> Setting is on", "Please visit library tab at least once with the correct boiii path!, you also need to have at least 1 item!")
                     return
 
                 with open(LIBRARY_FILE, 'r') as file:
                     lib_data = json.load(file)
 
-                for item in lib_data:
-                    item_id = item["id"]
-                    item_date = item["date"]
-                    if_id_needs_update(item_id, item_date, item["text"])
+                item_ids = [item["id"] for item in lib_data]
+                item_dates = {item["id"]: item["date"] for item in lib_data}
+                texts = {item["id"]: item["text"] for item in lib_data}
+
+                if_ids_need_update(item_ids, item_dates, texts)
+
             except:
-                show_message("Error checking for item updates!", "Please visit library tab at least once with the correct boiii path!, you also need to have at lease 1 item!")
+                show_message("Error checking for item updates!", "Please visit the library tab at least once with the correct boiii path!, you also need to have at least 1 item!")
                 return
 
         check_for_update()