From 68f6be23a682ab5fb1ce37ade09b036939763fe1 Mon Sep 17 00:00:00 2001
From: RaidMax <raidmax@live.com>
Date: Sun, 7 Jul 2019 17:57:06 -0500
Subject: [PATCH] require minimum kills before recoil threshold evaluated make
 sure edit configuration link on webfront visible when accessing via localhost

---
 Application/RconParsers/BaseRConParser.cs |  5 ++---
 Plugins/Stats/Cheat/Detection.cs          | 14 +-------------
 Plugins/Stats/Cheat/Thresholds.cs         |  1 +
 WebfrontCore/Views/Shared/_Layout.cshtml  |  2 +-
 4 files changed, 5 insertions(+), 17 deletions(-)

diff --git a/Application/RconParsers/BaseRConParser.cs b/Application/RconParsers/BaseRConParser.cs
index 7d9ed1ef0..562338773 100644
--- a/Application/RconParsers/BaseRConParser.cs
+++ b/Application/RconParsers/BaseRConParser.cs
@@ -163,7 +163,7 @@ namespace IW4MAdmin.Application.RconParsers
                     };
 
 #if DEBUG
-                    if (client.NetworkId < 1000)
+                    if (client.NetworkId < 1000 && client.NetworkId > 0)
                     {
                         client.IPAddress = 2147483646;
                         client.Ping = 0;
@@ -182,5 +182,4 @@ namespace IW4MAdmin.Application.RconParsers
 
             return StatusPlayers;
         }
-    }
-}
+    }}
diff --git a/Plugins/Stats/Cheat/Detection.cs b/Plugins/Stats/Cheat/Detection.cs
index b4691eb69..81bfcfe5a 100644
--- a/Plugins/Stats/Cheat/Detection.cs
+++ b/Plugins/Stats/Cheat/Detection.cs
@@ -159,7 +159,6 @@ namespace IW4MAdmin.Plugins.Stats.Cheat
             }
             #endregion
 
-
             #region STRAIN
             double currentStrain = Strain.GetStrain(hit.Distance / 0.0254, hit.ViewAngles, Math.Max(50, hit.TimeOffset - LastOffset));
 #if DEBUG == true
@@ -205,7 +204,7 @@ namespace IW4MAdmin.Plugins.Stats.Cheat
             var lifeTimeHits = ClientStats.HitLocations.Sum(_loc => _loc.HitCount);
             ClientStats.AverageRecoilOffset = (ClientStats.AverageRecoilOffset * (lifeTimeHits - 1) + hitRecoilAverage) / lifeTimeHits;
 
-            if (sessionAverageRecoilAmount == 0 && HitCount >= Thresholds.LowSampleMinKills)
+            if (HitCount >= Thresholds.LowSampleMinKills && Kills > Thresholds.LowSampleMinKillsRecoil && sessionAverageRecoilAmount == 0)
             {
                 results.Add(new DetectionPenaltyResult()
                 {
@@ -215,17 +214,6 @@ namespace IW4MAdmin.Plugins.Stats.Cheat
                     Type = DetectionType.Recoil
                 });
             }
-
-            if (ClientStats.AverageRecoilOffset == 0 && HitCount >= Thresholds.HighSampleMinKills)
-            {
-                results.Add(new DetectionPenaltyResult()
-                {
-                    ClientPenalty = EFPenalty.PenaltyType.Ban,
-                    Value = ClientStats.AverageRecoilOffset,
-                    HitCount = lifeTimeHits,
-                    Type = DetectionType.Recoil
-                });
-            }
             #endregion
 
             #region SESSION_RATIOS
diff --git a/Plugins/Stats/Cheat/Thresholds.cs b/Plugins/Stats/Cheat/Thresholds.cs
index 549d1872a..b85a11697 100644
--- a/Plugins/Stats/Cheat/Thresholds.cs
+++ b/Plugins/Stats/Cheat/Thresholds.cs
@@ -26,6 +26,7 @@ namespace IW4MAdmin.Plugins.Stats.Cheat
         public const int MediumSampleMinKills = 30;
         public const int HighSampleMinKills = 100;
         public const double KillTimeThreshold = 0.2;
+        public const int LowSampleMinKillsRecoil = 5;
 
         public const double MaxStrainBan = 0.9;
 
diff --git a/WebfrontCore/Views/Shared/_Layout.cshtml b/WebfrontCore/Views/Shared/_Layout.cshtml
index 7655fbafc..6f1e1c564 100644
--- a/WebfrontCore/Views/Shared/_Layout.cshtml
+++ b/WebfrontCore/Views/Shared/_Layout.cshtml
@@ -57,7 +57,7 @@
                             <div class="dropdown-menu p-0" aria-labelledby="account_dropdown">
                                 <a asp-controller="Console" asp-action="Index" class="dropdown-item bg-dark text-muted text-center text-lg-left">@loc["WEBFRONT_NAV_CONSOLE"]</a>
                                 <a asp-controller="Client" asp-action="ProfileAsync" asp-route-id="@ViewBag.User.ClientId" class="dropdown-item bg-dark text-muted text-center text-lg-left">@loc["WEBFRONT_NAV_PROFILE"]</a>
-                                @if (ViewBag.User.Level == SharedLibraryCore.Database.Models.EFClient.Permission.Owner)
+                                @if (ViewBag.User.Level >= SharedLibraryCore.Database.Models.EFClient.Permission.Owner)
                                 {
                                     <a asp-controller="Configuration" asp-action="Edit" class="dropdown-item bg-dark text-muted text-center text-lg-left">@loc["WEBFRONT_NAV_EDIT_CONFIGURATION"]</a>
                                 }